Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate to NearToken #333

Merged
merged 10 commits into from
Oct 29, 2023
Merged

refactor: Migrate to NearToken #333

merged 10 commits into from
Oct 29, 2023

Conversation

iho
Copy link
Contributor

@iho iho commented Oct 27, 2023 •
edited
Loading

Closes #332

@frol
Copy link
Collaborator

frol commented Oct 27, 2023

@iho I would suggest to actually use NearToken and NearGas as function arguments types instead of u64/u128, and re-export them from near_workspaces (see what is the best place for the type to be imported from the user perspective)

@iho iho force-pushed the iho_migrate_to_near_token branch from 37728f5 to 4b3c238 Compare October 28, 2023 16:22
@iho iho marked this pull request as ready for review October 29, 2023 07:56
frol
frol requested changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, apply the review comments to the whole PR (I did not comment on duplicates)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/src/croncat.rs Show resolved Hide resolved
examples/src/croncat.rs Outdated Show resolved Hide resolved
examples/src/ref_finance.rs Outdated Show resolved Hide resolved
workspaces/src/rpc/client.rs Outdated Show resolved Hide resolved
workspaces/src/types/mod.rs Outdated Show resolved Hide resolved
workspaces/tests/batch_tx.rs Outdated Show resolved Hide resolved
workspaces/tests/cross_contract.rs Outdated Show resolved Hide resolved
workspaces/tests/patch_state.rs Outdated Show resolved Hide resolved
frol
frol requested changes Oct 29, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
workspaces/Cargo.toml Outdated Show resolved Hide resolved
workspaces/src/network/sandbox.rs Outdated Show resolved Hide resolved
@frol frol merged commit 6b34e4c into near:main Oct 29, 2023
6 checks passed
@frol frol mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor NEAR tokens usages to use a strictly typed near-token crate
2 participants
@iho @frol